-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor feature testing for spec tests #6737
Conversation
6078560
to
b43440f
Compare
b43440f
to
aa593cf
Compare
…testing Electra types.
@michaelsproul @pawanjay176 would you mind reviewing this since you're both working on spec tests on electra? Thanks! |
FYI I'm working on the PeerDAS spec tests for alpha.10 as part of #6736. |
Squashed commit of the following: commit 898d05e Merge: ffbd25e 7e0cdde Author: Jimmy Chen <[email protected]> Date: Tue Dec 24 14:41:19 2024 +1100 Merge branch 'unstable' into refactor-ef-tests-features commit ffbd25e Author: Jimmy Chen <[email protected]> Date: Tue Dec 24 14:40:38 2024 +1100 Fix `SszStatic` tests for PeerDAS: exclude eip7594 test vectors when testing Electra types. commit aa593cf Author: Jimmy Chen <[email protected]> Date: Fri Dec 20 12:08:54 2024 +1100 Refactor spec testing for features and simplify usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this prior to the Electra alpha.10 PR, as I'm still working on the tests there (this PR: #6731).
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c9747fb |
Proposed Changes
FeatureName
usage.Additional Details
Removed previously hard coded
EIP7594_*
constants, and specify the feature tests at the handler level, this is more flexible, and allows for multiple features to be developed in parallel. For example:When running a test for a feature, tests used to be written this way:
This is quite verbose and may lead to inconsistency between tests. This has been modified to specify the fork at the
FeatureName
level, so the fork used is only specified once in thefeature_name.fork_name()
function.